[18.0][MIG][IMP] sale_restricted_qty by bosd · Pull Request #3959 · OCA/sale-workflow

bosd · 2025-10-21T15:29:42Z

Maybe this is usefull for somebody. It contains the improvements from 17.0 (#2997 ) and the original migration to 18.0.

Complete redesign of the inheritance model using an own/inherited/computed pattern. Each quantity setting (min, max, multiple-of)
now has three layers: sale_own_* (set directly), sale_inherited_* (from parent), and sale_* (effective combined value). This replaces
the old flat manual_* fields.
Mixin refactored with _sale_restricted_qty_parent_field class attribute — a single attribute on child models (parent_id, categ_id,
product_tmpl_id) drives all 12 inherited field lookups via callable @api.depends, eliminating 24+ repetitive method overrides per
child model.
Mixin renamed from product.restricted.qty.mixin to sale.product.restricted.qty.mixin to reflect its sale-specific scope.
Merged duplicated model inheritance into a single clean structure.

Blocking/Warning restriction mode

Replaced the old force/not_force/use_parent selection with a cleaner Blocking/Warning (1/0) selection per constraint type (min,
max, multiple-of), each with own/inherited/effective layers.

Bug fixes

Skip quantity restriction checks for confirmed sale order lines — prevents false validation errors on historical data.
Float precision — use float_is_zero with UoM rounding for multiple-of quantity modulo checks to avoid floating-point artifacts.
Logic bugs in compute methods fixed and covered by tests.

Usability

Auto-populate quantity with the minimum when a product with an enforced min qty is selected on a sale order line.
Order name included in validation error messages for easier identification.
Improved field help texts explaining Blocking vs Warning behavior.

Was 🤼‍♂️ with git, so the improvement commit author is assigned to me instead of alex.

bosd · 2025-10-21T16:05:16Z

Still needs some work..

Video_2025-10-21_18-02-04.mp4

… and manual_force_sale_max_qty (imp user UI)

… other module & pep8

Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_restricted_qty/

Currently translated at 100.0% (51 of 51 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_restricted_qty/it/

This commit brings the enhanced functionality from the improved version while maintaining Odoo 18.0 compatibility. Includes: - Enhanced model architecture with better inheritance - Improved field names and functionality - Better UI with proper decorations and warnings - Odoo 18.0 view compatibility fixes [ADD] sale_restricted_qty: Add German and Dutch translation files Add skeleton translation files for German (de.po) and Dutch (nl.po) languages. These files follow OCA standards for internationalization: - Proper headers with language codes - Correct plural forms for respective languages - Consistent with existing translation files in the module

Merge duplicated 'sale.order.line' model inheritance from sale.py and sale_order_line.py The improved model structure from sale_order_line.py replaces the original migration model. This resolves pylint warning R8180 about considering merging classes inherited to the same model.

…nforced Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> Add feature to automatically populate sale order line quantity with minimum quantity when: - Minimum quantity is set on the product - Minimum quantity restriction is enforced (restrict_min_qty = True) - Current quantity is 0 or not set This improves user experience by providing sensible defaults while maintaining validation for minimum quantities. Includes comprehensive unit tests covering: - Auto-population when enforced - No auto-population when not enforced - Preserving existing quantities - Onchange behavior simulation

rousseldenis · 2026-02-13T13:12:52Z

/ocabot migration sale_restricted_qty

OCA-git-bot · 2026-02-13T13:13:09Z

The migration issue (#3344) has not been updated to reference the current pull request because a previous pull request (#3609) is not closed.
Perhaps you should check that there is no duplicate work.
CC @samirGuesmi

rousseldenis · 2026-02-13T13:14:38Z

sale_restricted_qty/models/product_category.py

+        if not self.parent_id:
+            return super()._get_is_sale_inherited_min_qty_set()
+
+        self.ensure_one()


Why here and not at the function beginning ?

rousseldenis · 2026-02-13T13:16:04Z

sale_restricted_qty/models/product_restricted_qty_mixin.py

-class ProductMinMultipleMixin(models.AbstractModel):
+
+class ProductRestrictedQtyMixin(models.AbstractModel):
    _name = "product.restricted.qty.mixin"


As this is 'sale' oriented, I would have renamed "sale.product..."

rousseldenis · 2026-02-13T13:19:51Z

sale_restricted_qty/models/product_template.py

+        self.ensure_one()
+        return self.categ_id.sale_min_qty
+
+    @api.depends("categ_id.is_sale_restrict_min_qty_set")


To avoid all these overrides (for only depends()) in products and in categories, I would have added a private field in mixin like _sale_restricted_qty_field that would have been called in mixin depends.

…e overrides Address PR OCA#3959 review comments: - Rename mixin to sale.product.restricted.qty.mixin - Move ensure_one() to beginning of _get_* methods - Add _sale_restricted_qty_parent_field class attribute with callable @api.depends to avoid 24+ method overrides per child model

bosd · 2026-02-26T11:40:02Z

@rousseldenis Thanks for the review, the items hass been adressed. Is it ok now? Can we push this one forward?

rousseldenis

Seems lighter. LGTM

bosd · 2026-02-27T11:37:11Z

@rousseldenis Can you please merge?

alexey-pelykh

Solid migration and redesign. The own/inherited/computed pattern for hierarchical quantity constraints is well-structured and the test coverage is thorough.

A few observations:

Typo in .pot: "Sale Miltiple qty" should be "Sale Multiple qty" -- this propagates to all .po files. Likely an auto-extraction artifact, but worth regenerating.
is_sale_own_*_set fields not stored on mixin: is_sale_own_min_qty_set, is_sale_own_max_qty_set, is_sale_own_multiple_of_qty_set are plain fields.Boolean() without store=True on the mixin definition. This is fine since they default to stored, just noting for consistency with the computed booleans that have explicit store=True.
_compute_restricted_qty_constraints not stored: The is_below_min_qty, is_above_max_qty, is_not_multiple_of_qty fields on sale.order.line are computed without store=True. This is intentional (avoids stale data on qty changes), but means every form/list render triggers recomputation. Acceptable for sale order line volumes.
Float modulo in multiple-of check: qty % line.multiple_of_qty != 0 uses float modulo which can have precision issues. Consider using float_compare or float_round from odoo.tools for robustness, though for typical order quantities this is unlikely to cause real issues.
Migration handles multiple_of restrict: The migration script handles min_qty and max_qty restrict fields but not multiple_of_qty restrict (the for field in ["min_qty", "max_qty"] loop in migrate_selection_and_flags). If the previous version had a manual_force_sale_multiple_qty column, it would be missed. If it didn't exist, this is fine.
Legacy .pot file: sale_order_min_qty.pot is included alongside sale_restricted_qty.pot. Should this be removed if the module was renamed?

Overall LGTM. The architecture is clean, tests cover the inheritance chain well including UoM conversion edge cases, and the migration script handles the data transition correctly.

alexey-pelykh · 2026-03-01T16:52:31Z

sale_restricted_qty/models/sale.py

+        "restrict_max_qty",
+        "is_multiple_of_qty_set",
+        "multiple_of_qty",
+        "restrict_multiple_of_qty",


Float modulo (qty % line.multiple_of_qty) can produce precision artifacts with floats. Consider float_is_zero(qty % line.multiple_of_qty, precision_rounding=...) from odoo.tools.float_utils for robustness. Minor concern for typical order quantities.

alexey-pelykh · 2026-03-01T16:52:31Z

sale_restricted_qty/migrations/18.0.1.0.0/pre-migration.py

+    """
+    for field in ["min_qty", "max_qty"]:
+        old_col = f"manual_force_sale_{field}"
+        new_col = f"sale_own_restrict_{field}"


This loop handles min_qty and max_qty restrict fields. Was there a manual_force_sale_multiple_qty column in the previous version? If so, it would need handling here too.

marielejeune · 2026-03-18T12:11:51Z

@rousseldenis I think the failing tests are not related to this PR. Moreover with 4 approved reviews, it may be time to merge it! Thanks

rousseldenis · 2026-03-18T13:06:51Z

@rousseldenis I think the failing tests are not related to this PR. Moreover with 4 approved reviews, it may be time to merge it! Thanks

Merge will not pass if tests are red. Usually, someone (a good will) will fix them in order to merge 😄

marielejeune · 2026-03-18T14:12:24Z

@bosd can you rebase your branch?

BhaveshHeliconia

Functional review LGTM!

marielejeune · 2026-03-19T15:28:07Z

Hi all,

I'm a bit surprised the way this PR was done.
I initially thought it just superseeded the original PR of @samirGuesmi (straightforward migration), with some new merged PRs in v17.0

However, updating the sources in our project, I see that the UX completely changed.
I agree this is better and a good improvement, however I notice these improvements come from a 17.0 non merged (and not fully reviewed) PR: #2997

I find it a bit strange to include an old open PR in the migration process of a higher version, without explicitly mentioning it in the description.

In my opinion before merging this 18.0 PR we should finish the 17.0 UX improvements PR from @alexey-pelykh so that we're sure it doesn't change, merge it, and then merge this 18.0 PR.

What do you think?

marielejeune · 2026-03-19T15:49:26Z

sale_restricted_qty/models/product_restricted_qty_mixin.py

 RESTRICTION_ENABLED = "1"
 RESTRICTION_DISABLED = "0"
 RESTRICTION_SELECTION = [
-    (RESTRICTION_ENABLED, "Yes"),
-    (RESTRICTION_DISABLED, "No"),
+    (RESTRICTION_ENABLED, "Blocking"),
+    (RESTRICTION_DISABLED, "Warning"),


Just repeating the comment I've added on the 17.0 PR:

Would be better to have real chars as selection values, it eases the code comprehension:

I would suggest something like RESTRICTION_ENABLED = "enabled", "restricted" or "blocking", and RESTRICTION_DISABLED = "disabled", "unrestricted" or "warning".

@marielejeune Good point!
I would propose to do that in a follow-up pr.
We already using this module in production.

Introducing a version bump in this pr is undesirable, as well as adding a complex migration script for changing it withing the same version, would increase complexity for this nice to have.
IMO, better to handle it in a different pr.

rousseldenis · 2026-03-20T14:05:35Z

@bosd Could you put in PR description the different improvements you've added as this is not only a migration ? Thanks

sergiocorato · 2026-04-03T15:17:24Z

Hi all,

I'm a bit surprised the way this PR was done. I initially thought it just superseeded the original PR of @samirGuesmi (straightforward migration), with some new merged PRs in v17.0

However, updating the sources in our project, I see that the UX completely changed. I agree this is better and a good improvement, however I notice these improvements come from a 17.0 non merged (and not fully reviewed) PR: #2997

I find it a bit strange to include an old open PR in the migration process of a higher version, without explicitly mentioning it in the description.

In my opinion before merging this 18.0 PR we should finish the 17.0 UX improvements PR from @alexey-pelykh so that we're sure it doesn't change, merge it, and then merge this 18.0 PR.

What do you think?

It's possible to do these improvements here, if there is no one interested in v. 17.0 (I wouldn't personally check that version too).

Anyway, other then explain it, it could lead to a slower process of the migration, so it is not always a good idea.

In every case, commits of the improvements have to be squashed in 1 commit only.

sergiocorato

Squash improvement commits and explain their logic in the first comment of the PR at least, no code check.

[FIX]: sale_restricted_qty: Skip quantity restriction checks for confirmed sale order lines and add a reproduction test for historical data. [IMP] sale_restricted_qty: add order name to product quantity restriction error message [IMP] sale_restricted_qty: clean up legacy code and expand tests [IMP] sale_restricted_qty: use class attribute to eliminate repetitive overrides Address PR OCA#3959 review comments: - Rename mixin to sale.product.restricted.qty.mixin - Move ensure_one() to beginning of _get_* methods - Add _sale_restricted_qty_parent_field class attribute with callable @api.depends to avoid 24+ method overrides per child model [IMP] sale_restricted_qty: use float_is_zero for modulo check and remove legacy pot - Use float_is_zero with UoM rounding for multiple-of quantity checks to avoid float precision artifacts - Remove stale sale_order_min_qty.pot from the old module name

bosd · 2026-04-06T12:08:02Z

Done, commits squashed.

The work on this pr, and the one prior to it on version 17 have been open way too long.
Can we move forward with this?

bosd force-pushed the 18.0-mig-sale_restricted_qty branch from e0fb1e9 to 4ee7344 Compare October 23, 2025 19:52

mourad-ehm and others added 21 commits December 21, 2025 10:24

[IMP] rename module sale_order_min_qty to sale_restricted_qty

66bd812

[FIX] Update Readme & "use_parent" value to manual_force_sale_min_qty…

4e89333

… and manual_force_sale_max_qty (imp user UI)

[IMP] views & fix is_qty_less_min_qty & is_qty_bigger_max_qty

e256c3d

[IMP] add _get_sale_restricted_qty on sale to make qty overridable by…

165840f

… other module & pep8

[FIX] _compute_sale_restricted_qty

32bf0f9

[FIX] restricted_qty UserError Message

4f098fb

[FIX] openupgradelib requirements.txt

a36caea

[REF] refactor code to make it simplier and inheritable

fa7396f

[FIX] _compute_is_qty_less bigger multiple qty

d298b47

Added translation using Weblate (Italian)

9612d09

[14.0][MIG] sale_restricted_qty: Migration to 14.0

357fe6e

Translated using Weblate (Italian)

eaf0b30

Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/

[IMP] sale_restricted_qty: show sale_min sale_max optionally

8195430

[IMP] sale_restricted_qty: Change dp.get_precision digits

ca5dd84

Translated using Weblate (Italian)

e04e53e

Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/

Added translation using Weblate (French)

fcb45d1

[MIG] sale_restricted_qty: Migration to 16.0

10a7362

[UPD] Update sale_restricted_qty.pot

25bc08d

Translated using Weblate (Italian)

7cbc948

Currently translated at 100.0% (51 of 51 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_restricted_qty/it/

[IMP] sale_restricted_qty: pre-commit auto fixes

5bd8f10

bosd force-pushed the 18.0-mig-sale_restricted_qty branch from 0a64620 to e8dc0b8 Compare December 21, 2025 10:03

samirGuesmi and others added 4 commits December 21, 2025 11:26

[MIG] sale_restricted_qty: Migration to 18.0

a4b4673

bosd force-pushed the 18.0-mig-sale_restricted_qty branch 2 times, most recently from 9eebebe to 15f837b Compare December 21, 2025 12:40

therbin200 mentioned this pull request Feb 13, 2026

[19.0][MIG] sale_restricted_qty #4154

Open

OCA-git-bot added this to the 18.0 milestone Feb 13, 2026

rousseldenis added the migration label Feb 13, 2026

rousseldenis reviewed Feb 13, 2026

View reviewed changes

rousseldenis approved these changes Feb 27, 2026

View reviewed changes

alexey-pelykh approved these changes Mar 1, 2026

View reviewed changes

marielejeune mentioned this pull request Mar 2, 2026

[18.0] sale_restricted_qty: Migration to 18.0 #3609

Closed

metaminux mentioned this pull request Mar 4, 2026

[18.0][BUG] sale_partner_primeship : tests are failing from 11pm to midnight #4192

Closed

BhaveshHeliconia approved these changes Mar 19, 2026

View reviewed changes

marielejeune reviewed Mar 19, 2026

View reviewed changes

sergiocorato suggested changes Apr 3, 2026

View reviewed changes

OCA-git-bot removed approved ready to merge labels Apr 3, 2026

bosd force-pushed the 18.0-mig-sale_restricted_qty branch from 59b427d to 5306563 Compare April 6, 2026 11:48

bosd requested a review from sergiocorato April 6, 2026 12:08

Uh oh!

Conversation

bosd commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bosd commented Oct 21, 2025

Uh oh!

rousseldenis commented Feb 13, 2026

Uh oh!

OCA-git-bot commented Feb 13, 2026

Uh oh!

rousseldenis Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

rousseldenis Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

rousseldenis Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

bosd commented Feb 26, 2026

Uh oh!

rousseldenis left a comment

Choose a reason for hiding this comment

Uh oh!

bosd commented Feb 27, 2026

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Uh oh!

alexey-pelykh Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

alexey-pelykh Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

marielejeune commented Mar 18, 2026

Uh oh!

rousseldenis commented Mar 18, 2026

Uh oh!

marielejeune commented Mar 18, 2026

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

marielejeune commented Mar 19, 2026

Uh oh!

marielejeune Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rousseldenis Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

bosd Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

rousseldenis commented Mar 20, 2026

Uh oh!

sergiocorato commented Apr 3, 2026

Uh oh!

sergiocorato left a comment

Choose a reason for hiding this comment

Uh oh!

bosd commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

bosd commented Oct 21, 2025 •

edited

Loading

marielejeune Mar 19, 2026 •

edited

Loading